Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live tag - Fix animation flash on Safari #239

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Live tag - Fix animation flash on Safari #239

merged 2 commits into from
Apr 27, 2024

Conversation

alexzhang1618
Copy link
Contributor

Info

Fixing an animation bug where there were weird flashes for the live tag on Safari

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

after:
https://github.com/acmucsd/membership-portal-ui-v2/assets/27360825/80e42d9f-c0d1-4a84-8ae7-43af4355e027

@vercel Vercel
Copy link

vercel bot commented Apr 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 1:15am
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 1:15am

nik-dange
nik-dange approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:neckbeard: looks good to me!

SheepTester
SheepTester approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it works

@alexzhang1618 alexzhang1618 merged commit 03e2a12 into main Apr 27, 2024
8 checks passed
@alexzhang1618 alexzhang1618 deleted the bug/animation-flash branch April 27, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SheepTester SheepTester SheepTester approved these changes

@nik-dange nik-dange nik-dange approved these changes

@farisashai farisashai Awaiting requested review from farisashai farisashai is a code owner

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

Assignees

@alexzhang1618 alexzhang1618

Labels
PR: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexzhang1618 @nik-dange @SheepTester